Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should include npm run build:prod #910

Closed
guaka opened this issue Dec 4, 2018 · 1 comment
Closed

CI should include npm run build:prod #910

guaka opened this issue Dec 4, 2018 · 1 comment

Comments

@guaka
Copy link
Contributor

guaka commented Dec 4, 2018

If npm run build:prod doesn't succeed CI shouldn't give green light.

Example #790 passed, but ends up being a problem when building for prod.

This relates to #828, as ideally CI would simply build a complete new server from scratch.
@simison
Copy link
Contributor

simison commented Dec 4, 2018 •
edited
Loading

as ideally CI would simply build a complete new server from scratch.

it does :-) (just in wrong NODE_ENV)

This was referenced Dec 4, 2018
Merged
Merged
guaka pushed a commit that referenced this issue Dec 4, 2018
.travis.yml: NODE_ENV=production
6ce6b86 
#910 NODE_ENV=production
@guaka guaka mentioned this issue Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guaka @simison