Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.18.0] Add Group Metadata Consolidation and Vacuuming #1833

Closed
wants to merge 4 commits into from
Closed

[2.18.0] Add Group Metadata Consolidation and Vacuuming #1833

wants to merge 4 commits into from

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Sep 19, 2023 •
edited
Loading

Depends on TileDB-Inc/TileDB#4412. Will be available in 2.18.0.

Changes

  • Addition of Group.consolidate_metadata and Group.vacuum_metadata
  • Move unit tests that do not test group metadata from GroupMetadataTest to GroupTestCase

@nguyenv
Copy link
Collaborator Author

nguyenv commented Sep 19, 2023

[sc-34410]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #34410: Add Group Metadata Consolidation and Vacuuming.

@nguyenv nguyenv changed the title [WIP] Add Consolidation and Vacuuming For Group Metadata [WIP] Add Group Metadata Consolidation and Vacuuming Sep 19, 2023
@bkmartinjr bkmartinjr mentioned this pull request Sep 20, 2023
Closed
@nguyenv
Copy link
Collaborator Author

nguyenv commented Oct 12, 2023 •
edited
Loading

nullptr issue has been fixed by #4412. Awaiting release 2.18.0.

@nguyenv nguyenv changed the title [WIP] Add Group Metadata Consolidation and Vacuuming [2.17.2] Add Group Metadata Consolidation and Vacuuming Oct 12, 2023
@nguyenv nguyenv force-pushed the viviannguyen/consolidate-vac-groups branch from bc68541 to aa8188d Compare October 26, 2023 15:42
@nguyenv nguyenv changed the title [2.17.2] Add Group Metadata Consolidation and Vacuuming Add Group Metadata Consolidation and Vacuuming Oct 26, 2023
@nguyenv nguyenv marked this pull request as ready for review October 26, 2023 15:43
@nguyenv nguyenv requested a review from ihnorton October 26, 2023 15:43
@nguyenv nguyenv force-pushed the viviannguyen/consolidate-vac-groups branch 2 times, most recently from 315e824 to fa52467 Compare November 1, 2023 15:10
@nguyenv nguyenv force-pushed the viviannguyen/consolidate-vac-groups branch from df33642 to 4230aa4 Compare November 2, 2023 15:06
@nguyenv nguyenv changed the title Add Group Metadata Consolidation and Vacuuming [2.18.0] Add Group Metadata Consolidation and Vacuuming Nov 2, 2023
ihnorton
ihnorton approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests

@nguyenv
Copy link
Collaborator Author

nguyenv commented Nov 27, 2023

Cherry picked to #1869.

@ihnorton ihnorton closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyenv @ihnorton