Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TileDB 2.18.0 #1869

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Update to TileDB 2.18.0 #1869

merged 5 commits into from
Nov 28, 2023

Conversation

ihnorton
Copy link
Member

No description provided.

@ihnorton ihnorton force-pushed the ihn/upd-2.18 branch 2 times, most recently from 2ab8d30 to 0d652c7 Compare November 20, 2023 04:50
@ihnorton ihnorton changed the title NOMERGE test 2.18.0-rc4 Update to TileDB 2.18.0 Nov 21, 2023
ihnorton and others added 4 commits November 22, 2023 14:34
@ihnorton
Bump to TileDB 2.18.0, fix build system issues
465c8a2
@davisp @ihnorton
Release the GIL while consolidating
0d92a6a 
I stumbled over this while attempting to log stats during consolidation.
Turns out when we don't release the gil the background thread can't run.
@nguyenv @ihnorton
Add Consolidation and Vacuuming For Group Metadata
658f4ef
@ihnorton
Update HISTORY for 0.24.0 against TileDB 2.18
1f410ad
@ihnorton ihnorton marked this pull request as ready for review November 27, 2023 22:20
@ihnorton
Copy link
Member Author

ihnorton commented Nov 27, 2023 •
edited
Loading

Wheel check:

  • version
In [1]: import tiledb

In [2]: tiledb.version(), tiledb.libtiledb.version()
Out[2]: ((0, 24, 0), (2, 18, 0))
  • confirmed s3 support
  • ran all tests locally

@ihnorton ihnorton requested review from nguyenv and johnkerl November 27, 2023 22:26
@nguyenv nguyenv mentioned this pull request Nov 27, 2023
Closed
johnkerl
johnkerl reviewed Nov 27, 2023
View reviewed changes
HISTORY.md
@@ -1,3 +1,16 @@
# Release 0.24.0

* TileDB-Py 0.24.0 includes TileDB Embedded [2.18.0](https://github.com/TileDB-Inc/TileDB/releases/tag/2.18.0)
Copy link
Contributor

@johnkerl johnkerl Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihnorton TBH I'd be happy if we deferred 0.24.0 until 2.18.2

Otherwise we'll need to do this all over again

Just my $0.02, not sure if that would be acceptable to everyone

nguyenv
nguyenv reviewed Nov 27, 2023
View reviewed changes
HISTORY.md Show resolved Hide resolved
@ihnorton ihnorton merged commit 33bfac9 into dev Nov 28, 2023
48 of 57 checks passed
@ihnorton ihnorton deleted the ihn/upd-2.18 branch November 28, 2023 03:25
@ihnorton ihnorton mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenv nguyenv nguyenv left review comments

@johnkerl johnkerl johnkerl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ihnorton @johnkerl @nguyenv @davisp