Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null cfg in group consolidate_metadata and vacuum_metadata #4412

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Allow null cfg in group consolidate_metadata and vacuum_metadata #4412

merged 1 commit into from
Oct 12, 2023

Conversation

bekadavis9
Copy link
Contributor

@bekadavis9 bekadavis9 commented Oct 11, 2023 •
edited by KiterLuc
Loading

TYPE: BUG
DESC: Allow null cfg in group consolidate_metadata and vacuum_metadata

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #34378: Group::consolidate_metadata Errors Out With Default config=nullptr Argument.

@bekadavis9 bekadavis9 requested review from davisp and nguyenv October 11, 2023 22:14
nguyenv
nguyenv approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@nguyenv nguyenv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments earlier, but I looked at the code again and nevermind - deleted them.

@KiterLuc KiterLuc changed the title Bug fix: Allow nullptr Config in Group::consolidate_metadata and Grou… Allow null cfg in group consolidate_metadata and vacuum_metadata Oct 12, 2023
@KiterLuc KiterLuc merged commit e3967fa into dev Oct 12, 2023
@KiterLuc KiterLuc deleted the rd/bug_fix-group-consolidate_metadata branch October 12, 2023 06:14
@nguyenv nguyenv mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenv nguyenv nguyenv approved these changes

@davisp davisp Awaiting requested review from davisp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekadavis9 @nguyenv @KiterLuc