-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS fixes #3167
iOS fixes #3167
Conversation
thank for this PR, it looks good except #2744 Unblock the main thread while replacing the source (#2744 (comment)) We already experiment this change, but it causes crash when fast changing source... The good fix has be be discussed (I think I know the good fix but this is a big architecture change ...) |
This reverts commit 12d7dd6.
…ios-fix * commit '23a39e8f5fffbbdcfc72a4c0d7777763e273cd6d': chore: fix build issue Update issue templates feat: RN 0.73 support Fix ids in exo_player_control_view fix: remove dummy nativeOnly
Thank you, I revert #2744 |
@freeboub the main thread blocking makes this library unusable for us in the real world with bad internet connection trying to scroll a feed of video items. Do you think the fix is safe to use for multiple video elements, with only one fixed source at a time? (or mounting/unmounting with new source). Thank you. |
Also in the same boat with the blocking main thread, without knowing too much about the internals can we have this as an optional so additional prop such as dangerouslySwapIosVideoSource as a bool on the player component? |
I totally understand the issue of startup I revert following change: 1f27ffb |
#3166 Memory leaks
#3085 onFullscreen call backs are never fired
#3040 [Bug] Fullscreen broken on iOS due to #3017
#2744 Unblock the main thread while replacing the source (cf comment)