Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Memory leaks #3166

Closed
cguino opened this issue Jul 6, 2023 · 1 comment
Closed

[iOS] Memory leaks #3166

cguino opened this issue Jul 6, 2023 · 1 comment

Comments

@cguino
Copy link
Contributor

cguino commented Jul 6, 2023

Bug

Mount then unmount Video component result in swift init called but deinit is never called

Platform

  • iOS

Environment info

React native info output:

System:
  OS: macOS 13.2
  CPU: (8) x64 Apple M1
  Memory: 25.48 MB / 16.00 GB
  Shell:
    version: 5.8.1
    path: /bin/zsh
Binaries:
  Node:
    version: 18.9.1
    path: /var/folders/m6/g_g8x9mx6bsdd0z4bz2h649r0000gn/T/yarn--1688635068292-0.5680216196061589/node
  Yarn:
    version: 1.22.19
    path: /var/folders/m6/g_g8x9mx6bsdd0z4bz2h649r0000gn/T/yarn--1688635068292-0.5680216196061589/yarn
  npm:
    version: 8.19.1
    path: /usr/local/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.12.1
    path: /Users/***/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK:
    API Levels:
      - "23"
      - "25"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 29.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.1
    System Images:
      - android-31 | Google Play ARM 64 v8a
    Android NDK: 22.1.7171670
IDEs:
  Android Studio: 2021.3 AI-213.7172.25.2113.9123335
  Xcode:
    version: 14.3/14E222b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/***/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.1
    wanted: 0.72.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Library version: 6.0.0-alpha.6

Steps To Reproduce

  1. Navigate to / Open a screen with a Video
  2. Start playing the video
  3. Go back / Unmount Video component
  4. Video is still running

Expected behaviour

Video should stop and RCTVideo should be deinit

@cguino cguino mentioned this issue Jul 6, 2023
@freeboub
Copy link
Collaborator

another fix integrated in next alpha.7 or beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants