Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ensure controls are not displayed when disabled by user #3017

Conversation

freeboub
Copy link
Collaborator

Fix an issue found when testing with basic sample.
if you disable controls, set fullscreen={true} and fullscreen={false}
when leaving fullscreen controls are displayed even if controls are false

@vargajacint
Copy link

LGTM!

@freeboub freeboub merged commit f1c7bdb into TheWidlarzGroup:master Feb 7, 2023
@cguino cguino mentioned this pull request Jul 6, 2023
freeboub added a commit that referenced this pull request Jul 10, 2023
#3166 Memory leaks
#3085 onFullscreen call backs are never fired
#3040 [Bug] Fullscreen broken on iOS due to #3017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants