Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Import/Export Service causes issue for tagged processing #100

Closed
ansoni opened this issue Mar 27, 2014 · 1 comment
Closed

AWS Import/Export Service causes issue for tagged processing #100

ansoni opened this issue Mar 27, 2014 · 1 comment

Comments

@ansoni
Copy link
Contributor

ansoni commented Mar 27, 2014

Unfortunately, AWS Import/Export has a '/' in its name so we fail when processing tagged resources:

 2014-03-17 21:56:20,624 [com.netflix.ice.processor.BillingFileProcessor] ERROR      StackTrace  - Full Stack Trace:
 java.io.FileNotFoundException: /mnt/ice_processor/tagdb_AWS Import/Export (No such file or directory)
         at java.io.FileOutputStream.open(Native Method)
         at java.io.FileOutputStream.<init>(FileOutputStream.java:212)
         at java.io.FileOutputStream.<init>(FileOutputStream.java:160)
         at com.netflix.ice.processor.TagGroupWriter.archive(TagGroupWriter.java:64)
         at com.netflix.ice.processor.BillingFileProcessor.archive(BillingFileProcessor.java:412)
         at com.netflix.ice.processor.BillingFileProcessor.poll(BillingFileProcessor.java:235)
         at com.netflix.ice.common.Poller.doWork(Poller.java:50)
         at com.netflix.ice.common.Poller.access$000(Poller.java:28)
         at com.netflix.ice.common.Poller$1.run(Poller.java:88)
         at java.lang.Thread.run(Thread.java:701)

I worked around this via some changes like:

      name = name.replaceAll("/","--");

but probably needs to be a centralized helper method(I'm also not sure what I may have broken).
@vfilanovsky
Copy link
Contributor

Yes, tag names are not sanitized. I'll see about fixing it

@ansoni ansoni mentioned this issue Jun 23, 2014
Closed
agreg pushed a commit to agreg/ice_cookbook that referenced this issue Jan 14, 2015
Fixed Berksfile to get rid of DEPRECATED warning
93b4613 
Work around Teevity/ice#100 by pre-creating the directories it expects to find
Added nginx_default_server attribute to make Nginx proxy all HTTP requests to Tomcat
Added reservation_capacity_poller_roles and reservation_capacity_poller_external_ids attributes to define per-account IAM roles and external ids to allow polling of reservation capacity in different accounts
Added logrotate_frequency and logrotate_rotate attributes to define log rotation frequency and retention for catalina.out
Added attributes for the remaining options in ice.properties
@agreg agreg mentioned this issue Jan 14, 2015
Merged
This was referenced Jan 20, 2015
Closed
Open
@NitriKx NitriKx closed this as completed in 0c21b05 Aug 2, 2017
NitriKx added a commit that referenced this issue Aug 2, 2017
@NitriKx
Merge branch 'integration'
eb33426 
* integration:
  Fixed the path of the generated ice.properties file in the instructions shown at the end of the install.sh script
  Do not fail in install.sh if the "message.properties" file has already been deleted
  Do not fail in install.sh if the local work directories already exists
  Force the install.sh script to exit if an error occur
  Add a syntax validation on install.sh in the Travis CI testing process
  Fixed OS detection in install.sh
  Add support for localized billing accounts
  Fix Grails version in URL
  Update README with reference to ice.config.location
  Allow extra configuration file
  Add us-east-1f support
  minor fixes
  Highstock CDN supports HTTPS now, let's use it by default
  Continue grouping resources even if ResourceId is missing
  Parse services with '/'. Fixes #100
  Upgrade to Grails 2.4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ansoni @vfilanovsky