Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Updates #113

Closed
wants to merge 15 commits into from
Closed

Authentication Updates #113

wants to merge 15 commits into from

Conversation

ansoni
Copy link
Contributor

@ansoni ansoni commented Jun 23, 2014

Hello,
During internal productization, I added several feature to Ice. This is a commit of those changes:

  • addition of "ice.use_blended" as a toggle between blended/unblended. Default behavior is blended.
  • addition of a new route to redirect to the application context when someone hits '/'
  • addition of an authentication framework. default is not enabled
  • addition of a passphrase protected login plugin
  • addition of a SAML login plugin
  • updated README for these additions.

The first commit around services with '/' in the name was later removed with #100 being submitted in its place.

Lots of changes I know.

Thanks,

Anthony

@cloudbees-pull-request-builder

ice-pull-requests #43 SUCCESS
This pull request looks good

@grahamlyons
Copy link
Contributor

Maybe this could be a pull request per feature to make it easier to digest?

@ansoni
Copy link
Contributor Author

ansoni commented Jun 23, 2014

Let me see if I can sort it out.

@jasonshah
Copy link

I'm excited to see the SAML plugin come with this enhancement!

@ansoni
Copy link
Contributor Author

ansoni commented Jul 12, 2014

Glad to hear it. SAML was the whole reason for the login framework. It has the ability to limit what accounts are visible via the SAML assertion. This was a requirement for our internal usage.

Maintainers: Would it help if I annotated the sources? I'm not sure how to break this pull request into smaller chunks without re-branching and re-applying my code changes.

@ansoni
Copy link
Contributor Author

ansoni commented Jan 19, 2015

Closing this. I will re-work the pull request in the future.

@ansoni ansoni closed this Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants