add code for addressing services with '/' #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ice-pull-requests #60 SUCCESS |
|
Any feedback? |
|
ice-pull-requests #76 SUCCESS |
| @@ -28,8 +28,10 @@ public int compareTo(Tag t) { | |||
| }; | |||
|
|
|||
| public final String name; | |||
| public final String s3Name; | |||
There was a problem hiding this comment.
Where is this field used?
There was a problem hiding this comment.
Sorry, it has been a long week. Indeed their is some code that I have forgotten. Demuxing my large pull request from last year:-)
-- Update code to use Tag.s3Name for S3 safe names
|
@vfilanovsky added missing code. Without these changes, "Details with Resource Groups" won't load Products if the user has any line items for AWS Import/Export Service. |
|
ice-pull-requests #78 SUCCESS |
| @@ -37,7 +37,7 @@ | |||
| private ReadWriteData data; | |||
|
|
|||
| DataWriter(String name, boolean loadData) throws Exception { | |||
|
|
|||
| name = name.replaceAll("/", "--"); | |||
There was a problem hiding this comment.
Perhaps it's better call Tag.toS3() method instead
|
PR #184 has been merged (which is an updated version of this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses Issue #100
This maps '/' (AWS Import/Export) to "--" since when the name is used as the key for an S3 Object, it ends up becoming part of the prefix.