SP-8555 tv os native message logo #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….swift; DocumentType changed to plain text in htmlToAttributedString in order to return text with no html markdown
…malformed URLs for GDPRVendor
…ssage_logo * SP-8330_appletv_html_crash: linter-suggested minor fixes unit test implemented NSAttributedString file removed NSAttributedString extension changes reversed replaceHTMLTag(withAttributes) added to NSAttributedString extension stripOutHtml method which deletes any css/html tags added to SPString.swift; DocumentType changed to plain text in htmlToAttributedString in order to return text with no html markdown
ConsentViewController/Classes/SourcePointClient/SPNativeUI.swift
Outdated
Show resolved
Hide resolved
|
@andresilveirah applied linter-suggested fixes. This is the blocker branch. Pls check it out! |
* develop: [SP-8236] "https://" is not included in SPPropertyName if it is already there (#357) SP-8288 ott unexpected response message endpoint (#353) SP-8346 fix old unit tests (#356) SP-8330 appletv html crash (#352) # Conflicts: # ConsentViewController/Classes/SourcePointClient/GDPRPrivacyManagerViewResponse.swift # ConsentViewController/Classes/SourcePointClient/SPPrivacyManagerRequestResponse.swift
|
Hey @andresilveirah ! I've merged develop branch in here so now PR has no conflicts & is consistent. Pls review! |
…ativeUISettings now
ConsentViewController/Classes/SourcePointClient/SPNativeUI.swift
Outdated
Show resolved
Hide resolved
ConsentViewController/Classes/SourcePointClient/GDPRPrivacyManagerViewResponse.swift
Outdated
Show resolved
Hide resolved
ConsentViewController/Classes/SourcePointClient/SPPrivacyManagerRequestResponse.swift
Outdated
Show resolved
Hide resolved
Nevazhnovu
added a commit
that referenced
this pull request
Feb 4, 2022
* develop: SP-7877 ott UI testing (#355) update CHANGELOG update XCFramework bump version to 6.4.1 move Objc project to cocoapods update spm version for SPMBuild Target add build SPM step to github test workflow import UIKit on Constants to fix SPM build namespace URL constants fix linting and namespace UI constants create SPMBuild app update XCFramework run pod install bump version to 6.4.0 run pod install update CHANGELOG SP-8555 tv os native message logo (#358) # Conflicts: # ConsentViewController/Classes/Constants.swift # ConsentViewController/Classes/SourcePointClient/GDPRPrivacyManagerViewResponse.swift # ConsentViewController/Classes/SourcePointClient/SPNativeUI.swift # ConsentViewController/Classes/SourcePointClient/SPPrivacyManagerRequestResponse.swift # ConsentViewController/Classes/Views/tvOS/NativePrivacyManager/Common/SPNativeScreenViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.