SP-8330 appletv html crash #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….swift; DocumentType changed to plain text in htmlToAttributedString in order to return text with no html markdown
|
@Nevazhnovu I'm changing the name of the PR from |
There was a problem hiding this comment.
@Nevazhnovu have you committed an empty file by mistake (NSAttributedString.swift) ?
What do you think of adding a unit test for the new method? Making sure it does remove the HTML tags from strings?
|
@andresilveirah Yup I did it accidentaly. Sure, starting right now |
andresilveirah
approved these changes
Jan 25, 2022
Nevazhnovu
added a commit
that referenced
this pull request
Jan 27, 2022
* develop: [SP-8236] "https://" is not included in SPPropertyName if it is already there (#357) SP-8288 ott unexpected response message endpoint (#353) SP-8346 fix old unit tests (#356) SP-8330 appletv html crash (#352) # Conflicts: # ConsentViewController/Classes/SourcePointClient/GDPRPrivacyManagerViewResponse.swift # ConsentViewController/Classes/SourcePointClient/SPPrivacyManagerRequestResponse.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to replace html tags with attributed string was bad idea. So they are simply stripped out in order to avoid the crash