-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SP-8288 ott unexpected response message endpoint #353
Merged
Nevazhnovu
merged 8 commits into
develop
from
SP-8288-ott-unexpected-response-message-endpoint
Jan 26, 2022
Merged
SP-8288 ott unexpected response message endpoint #353
Nevazhnovu
merged 8 commits into
develop
from
SP-8288-ott-unexpected-response-message-endpoint
Jan 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yUrl is malformed during ccpaPrivacyManagerView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nevazhnovu can you rebase this branch on top of develop
to make it easier to review?
@andresilveirah now the branch is consistent. Check it out! |
andresilveirah
approved these changes
Jan 26, 2022
Nevazhnovu
added a commit
that referenced
this pull request
Jan 27, 2022
* develop: [SP-8236] "https://" is not included in SPPropertyName if it is already there (#357) SP-8288 ott unexpected response message endpoint (#353) SP-8346 fix old unit tests (#356) SP-8330 appletv html crash (#352) # Conflicts: # ConsentViewController/Classes/SourcePointClient/GDPRPrivacyManagerViewResponse.swift # ConsentViewController/Classes/SourcePointClient/SPPrivacyManagerRequestResponse.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL? is replaced with String? for policyUrl both in Vendor and GDPRVendor structs