Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP-8097 implement onSPFinished #350

Merged
merged 2 commits into from
Dec 16, 2021
Merged

SP-8097 implement onSPFinished #350

merged 2 commits into from
Dec 16, 2021

Conversation

andresilveirah
Copy link
Member

@andresilveirah andresilveirah commented Dec 13, 2021 •
edited
Loading

  • implement onSPFinished delegate method
  • make sure onAction is always called on the main thread

The onSPFinished delegate method is guaranteed to be called once at the end of the SDK's lifecycle unless something goes wrong (in this case, the onError will be called instead).

@Nevazhnovu Nevazhnovu merged commit 2ed02e8 into develop Dec 16, 2021
Nevazhnovu added a commit that referenced this pull request Jan 26, 2022
@Nevazhnovu
Merge branch 'develop' into SP-8288-ott-unexpected-response-message-e…
ae9e7cf 
…ndpoint

* develop:
  SP-8330 appletv html crash (#352)
  SP-8097 implement `onSPFinished` (#350)
  Add event callback section
  Update README.md
@andresilveirah andresilveirah deleted the SP-8097_implement_onSPFinished branch February 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevazhnovu Nevazhnovu Awaiting requested review from Nevazhnovu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresilveirah @Nevazhnovu