Remove bookmark button #3217
Open
Remove bookmark button #3217
+0
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the CI has failed. I'll try rerunning it to see if its just a temporary issue. |
|
nvm I see its been fixed in #3212 |
rozyczko
reviewed
Feb 19, 2025
| </property> | ||
| <property name="icon"> | ||
| <iconset> | ||
| <normaloff>:/res/bookmark.png</normaloff>:/res/bookmark.png</iconset> |
There was a problem hiding this comment.
we can probably remove bookmark.png as well (and rebuild the resources)
rozyczko
approved these changes
Feb 19, 2025
|
Me, and Lucas were discussing the whole 'save state' feature as the code for this will likely have to change in order to be compatible with the new SasData objects from the refactoring project. We may discuss this more at the technical meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the bookmark button, and some other references to it. As discussed in #3213 , it doesn't appear to be implemented.
How Has This Been Tested?
Ran SasView. The bookmark button no longer appears. I tried loading the save states that used to contain a tag for it but from what I can understand, they are all in the old format anyway. I was getting errors but I don't think those were caused by this branch.
Review Checklist:
Documentation (check at least one)
Installers
Licencing (untick if necessary)