Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bookmark button #3217

Open
wants to merge 3 commits into
base: release_6.0.1
Choose a base branch
from
Open

Remove bookmark button #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e47ec6
Remove the bookmark button from the UI.
jamescrake-merani Feb 17, 2025
b1ab5e1
Remove mentions of bookmark in the documentation.
jamescrake-merani Feb 17, 2025
f382fb7
Remove bookmark from these save states.
jamescrake-merani Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sas/example_data/saved_states/fit_pr_and_invariant_project.svs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,6 @@
<fit_enable_low>False</fit_enable_low>
</state_6>
</history>
<bookmark/>
</invariant>
</SASentry>
<SASentry>
Expand Down
1 change: 0 additions & 1 deletion src/sas/example_data/saved_states/test.inv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,6 @@
</fit_enable_low>
</state_0>
</history>
<bookmark/>
</invariant>
</SASentry>
</SASroot>
13 changes: 0 additions & 13 deletions src/sas/qtgui/MainWindow/UI/MainWindowUI.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@
<addaction name="actionRedo"/>
<addaction name="actionCopy"/>
<addaction name="actionPaste"/>
<addaction name="actionBookmarks"/>
<addaction name="separator"/>
<addaction name="actionPrevious"/>
<addaction name="actionNext"/>
Expand Down Expand Up @@ -289,18 +288,6 @@
<string>Save Params to File</string>
</property>
</action>
<action name="actionBookmarks">
<property name="checkable">
<bool>true</bool>
</property>
<property name="icon">
<iconset>
<normaloff>:/res/bookmark.png</normaloff>:/res/bookmark.png</iconset>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove bookmark.png as well (and rebuild the resources)

</property>
<property name="text">
<string>Bookmarks</string>
</property>
</action>
<action name="actionPerspective">
<property name="text">
<string>Perspective</string>
Expand Down
10 changes: 0 additions & 10 deletions src/sas/qtgui/Perspectives/Fitting/media/fitting_help.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,16 +596,6 @@ To *paste* parameters, either:
If either operation is successful a message will appear in the info line at the
bottom of the SasView window.

Bookmark
^^^^^^^^

To *Bookmark* a *Fit Page* either:

* Select a *Fit Page* and then click on *Bookmark* in the tool bar, or
* Right-click and select the *Bookmark* in the popup menu.

.. ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ

.. _Status_bar:

Status Bar & Log Explorer
Expand Down
Loading