Bookmark button doesn't appear to actually do anything

[jamescrake-merani]

Describe the bug
While working on the redesign of the data explorer, I noticed that we currently have a 'bookmark' button on the top of the screen. This is the icon with a plus on it.

Clicking it seems to toggle it like a checkbox, but it doesn't appear to actually do anything. Looking at the code, I can find where it is defined in the UI

  <action name="actionBookmarks">
   <property name="checkable">
    <bool>true</bool>
   </property>
   <property name="icon">
    <iconset>
     <normaloff>:/res/bookmark.png</normaloff>:/res/bookmark.png</iconset>
   </property>
   <property name="text">
    <string>Bookmarks</string>
   </property>
  </action>

But I can't find anywhere else in the code that actually refers to this actionBookmarks, or anything related to bookmarking. I note that in the documentation, it says:

Bookmark
^^^^^^^^

To *Bookmark* a *Fit Page* either:

*  Select a *Fit Page* and then click on *Bookmark* in the tool bar, or
*  Right-click and select the *Bookmark* in the popup menu.

On the second point, I'm not sure where I would need to right click.

If this bookmarking feature hasn't been implemented, could we potentially just remove this button? If there is a desired feature that was meant to be here then I could look at implementing that in the data explorer redesign.

To Reproduce
Steps to reproduce the behavior:

1. Click on the boomark button at the top
2. Observe nothing happen

Expected behavior
Something to happen.

SasView version:

• Version: 6.0.0

Operating system:

• OS: Linux with Flatpak (but based on the code, I presume this happens on other operating systems)