Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust mocha assertions #30052

Merged
merged 3 commits into from
Aug 9, 2023
Merged

chore: Adjust mocha assertions #30052

merged 3 commits into from
Aug 9, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested review from a team as code owners August 9, 2023 18:29
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 7ff9ff8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #30052 (7ff9ff8) into develop (4349443) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30052      +/-   ##
===========================================
- Coverage    47.63%   47.58%   -0.06%     
===========================================
  Files          695      695              
  Lines        13102    13102              
  Branches      2286     2286              
===========================================
- Hits          6241     6234       -7     
- Misses        6524     6530       +6     
- Partials       337      338       +1     
Flag Coverage Δ
e2e 47.54% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 9e10f68 into develop Aug 9, 2023
@ggazzo ggazzo deleted the chore/adjust-mocha branch August 9, 2023 19:37
gabriellsh added a commit that referenced this pull request Aug 10, 2023
…et.Chat into feat/room-usercard-menus

* 'feat/room-usercard-menus' of github.com:RocketChat/Rocket.Chat:
  fix: Performance issue on Messages.countByType aggregation (#30062)
  chore:  split fuselage js/css (#30039)
  test: migrate test/unit/client/view to jest (#29992)
  chore: Adjust mocha assertions (#30052)
  fix: Performance issue on Engagement Dashboard aggregation (#30022)
  regression: Change header buttons location on `GroupPage` (#30042)
  regression: Sidebar missing default width (#30043)
  chore: high-contrast button-primary colors (#30036)
  fix: user creation using ADMIN_* variables (#30015)
  fix: Deleted DM rooms can't be closed (#29984)
MartinSchoeler pushed a commit that referenced this pull request Aug 11, 2023
MartinSchoeler pushed a commit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants