Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Performance issue on Engagement Dashboard aggregation #30022

Merged
merged 8 commits into from
Aug 9, 2023

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Aug 4, 2023

Tested on Open's database:

  • Original aggregation took 111 seconds to run
  • New aggregation took 5.4 seconds to run (20x faster)

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 2191550

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #30022 (2191550) into develop (856c235) will decrease coverage by 16.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #30022       +/-   ##
============================================
- Coverage    47.61%   31.07%   -16.55%     
============================================
  Files          693      561      -132     
  Lines        13071    10807     -2264     
  Branches      2283     2006      -277     
============================================
- Hits          6224     3358     -2866     
- Misses        6509     7244      +735     
+ Partials       338      205      -133     
Flag Coverage Δ
e2e 31.07% <ø> (-16.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok force-pushed the improve/engagement-dashboard-performance branch from ea5cf00 to 347c3ea Compare August 4, 2023 22:45
@rodrigok rodrigok force-pushed the improve/engagement-dashboard-performance branch from 347c3ea to af46e7d Compare August 4, 2023 22:46
@rodrigok rodrigok added this to the 6.2.12 milestone Aug 8, 2023
@rodrigok rodrigok changed the base branch from develop to release-6.3.1 August 8, 2023 21:00
@rodrigok rodrigok changed the base branch from release-6.3.1 to develop August 8, 2023 21:01
@rodrigok rodrigok marked this pull request as ready for review August 8, 2023 21:02
@rodrigok rodrigok requested a review from a team as a code owner August 8, 2023 21:02
sampaiodiego
sampaiodiego previously approved these changes Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 9, 2023
@kodiakhq kodiakhq bot merged commit 4349443 into develop Aug 9, 2023
@kodiakhq kodiakhq bot deleted the improve/engagement-dashboard-performance branch August 9, 2023 15:09
gabriellsh added a commit that referenced this pull request Aug 10, 2023
…et.Chat into feat/room-usercard-menus

* 'feat/room-usercard-menus' of github.com:RocketChat/Rocket.Chat:
  fix: Performance issue on Messages.countByType aggregation (#30062)
  chore:  split fuselage js/css (#30039)
  test: migrate test/unit/client/view to jest (#29992)
  chore: Adjust mocha assertions (#30052)
  fix: Performance issue on Engagement Dashboard aggregation (#30022)
  regression: Change header buttons location on `GroupPage` (#30042)
  regression: Sidebar missing default width (#30043)
  chore: high-contrast button-primary colors (#30036)
  fix: user creation using ADMIN_* variables (#30015)
  fix: Deleted DM rooms can't be closed (#29984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants