Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user creation using ADMIN_* variables #30015

Merged
merged 8 commits into from
Aug 8, 2023
Merged

fix: user creation using ADMIN_* variables #30015

merged 8 commits into from
Aug 8, 2023

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Aug 4, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Closes : #29855

@debdutdeb debdutdeb requested a review from a team as a code owner August 4, 2023 11:24
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: a6d8431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #30015 (a6d8431) into develop (2d372dc) will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30015      +/-   ##
===========================================
+ Coverage    48.83%   49.36%   +0.52%     
===========================================
  Files          703      726      +23     
  Lines        13784    14161     +377     
  Branches      2499     2502       +3     
===========================================
+ Hits          6732     6990     +258     
- Misses        6660     6782     +122     
+ Partials       392      389       -3     
Flag Coverage Δ
e2e 47.57% <ø> (+0.60%) ⬆️
unit 64.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego added this to the 6.3.1 milestone Aug 8, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 8, 2023
@kodiakhq kodiakhq bot merged commit b747f3d into develop Aug 8, 2023
@kodiakhq kodiakhq bot deleted the fix-ADMIN_vars branch August 8, 2023 21:31
gabriellsh added a commit that referenced this pull request Aug 10, 2023
…et.Chat into feat/room-usercard-menus

* 'feat/room-usercard-menus' of github.com:RocketChat/Rocket.Chat:
  fix: Performance issue on Messages.countByType aggregation (#30062)
  chore:  split fuselage js/css (#30039)
  test: migrate test/unit/client/view to jest (#29992)
  chore: Adjust mocha assertions (#30052)
  fix: Performance issue on Engagement Dashboard aggregation (#30022)
  regression: Change header buttons location on `GroupPage` (#30042)
  regression: Sidebar missing default width (#30043)
  chore: high-contrast button-primary colors (#30036)
  fix: user creation using ADMIN_* variables (#30015)
  fix: Deleted DM rooms can't be closed (#29984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Account Creation
5 participants