BasisTranslator causes transpiler performance regression #4632
Assignees
Labels
bug
Something isn't working
priority: high
status: pending PR
It has one or more PRs pending to solve this issue
Milestone
Comments
kdk
added a commit
to kdk/qiskit-terra
that referenced
this issue
Jul 1, 2020
When replacing source gates with their target implementations, the BasisTranslator pass had been assigning parameters for every gate replacement which is expensive (as it requires a deepcopy of the target DAG) and in most cases unnecessary (unless the source gate has parameters which need to be bound). This commit checks that the source gate needs parameter assignment, and uses the target implementation directly if not. (The round-trip to circuit for cases where parameter assignment will be addressed in a later PR.) Resolves Qiskit#4632 .
kdk
added
the
status: pending PR
mergify bot
added a commit
that referenced
this issue
Jul 8, 2020
…4636) When replacing source gates with their target implementations, the BasisTranslator pass had been assigning parameters for every gate replacement which is expensive (as it requires a deepcopy of the target DAG) and in most cases unnecessary (unless the source gate has parameters which need to be bound). This commit checks that the source gate needs parameter assignment, and uses the target implementation directly if not. (The round-trip to circuit for cases where parameter assignment will be addressed in a later PR.) Resolves #4632 . Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <[email protected]>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this issue
Aug 5, 2020
…iskit#4636) When replacing source gates with their target implementations, the BasisTranslator pass had been assigning parameters for every gate replacement which is expensive (as it requires a deepcopy of the target DAG) and in most cases unnecessary (unless the source gate has parameters which need to be bound). This commit checks that the source gate needs parameter assignment, and uses the target implementation directly if not. (The round-trip to circuit for cases where parameter assignment will be addressed in a later PR.) Resolves Qiskit#4632 . Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Information
What is the current behavior?
Since #4446 merged transpiler runtime performance has regressed, for example:
Steps to reproduce the problem
What is the expected behavior?
Suggested solutions
The text was updated successfully, but these errors were encountered: