BasisTranslator to only bind substitutions for parameterized gates. #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing source gates with their target implementations, the BasisTranslator pass had been assigning parameters for every gate replacement which is expensive (as it requires a deepcopy of the target DAG) and in most cases unnecessary (unless the source gate has parameters which need to be bound). This commit checks that the source gate needs parameter assignment, and uses the target implementation directly if not. (The round-trip to circuit for cases where parameter assignment will be addressed in a later PR.) Resolves Qiskit#4632 .
ajavadia
approved these changes
Jul 7, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…iskit#4636) When replacing source gates with their target implementations, the BasisTranslator pass had been assigning parameters for every gate replacement which is expensive (as it requires a deepcopy of the target DAG) and in most cases unnecessary (unless the source gate has parameters which need to be bound). This commit checks that the source gate needs parameter assignment, and uses the target implementation directly if not. (The round-trip to circuit for cases where parameter assignment will be addressed in a later PR.) Resolves Qiskit#4632 . Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing source gates with their target implementations, the
BasisTranslator pass had been assigning parameters for every gate
replacement which is expensive (as it requires a deepcopy of the
target DAG) and in most cases unnecessary (unless the source gate
has parameters which need to be bound).
This commit checks that the source gate needs parameter assignment,
and uses the target implementation directly if not. (The round-trip
to circuit for cases where parameter assignment will be addressed in
a later PR.)
Resolves #4632 .
Summary
Details and comments