fix(insights): Don't reset new insight when recording opened #21424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webjunkie
approved these changes
Apr 9, 2024
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 845 kB ℹ️ View Unchanged
|
|
Hmm, there's a couple failing E2E tests, and they're very valid. This is tricky. Closing in favor of a different approach in #21449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you opened a recording while making a new insight… well, you no longer had that insight:
Screen.Recording.2024-04-09.at.09.39.07.mov
Reported in ZEN-12286 (issue #1).
Changes
This was caused by an old branch in the code, which allowed easy resetting of the new insight by clicking the "New insight" navbar button again. However, this conflicted with the session recording ID hash param set by the player, which is why we also unintentionally reset the insight when merely opening a recording. Safer to remove this behavior.