Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Don't reset new insight when recording opened #21424

Closed
wants to merge 3 commits into from
Closed

fix(insights): Don't reset new insight when recording opened #21424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc390e7
fix(insights): Don't reset new insight when recording opened
Twixes Apr 9, 2024
be37d0e
Update UI snapshots for `chromium` (1)
github-actions[bot] Apr 9, 2024
3f09f8e
Merge branch 'master' into fix-new-insight-recording-reset
Twixes Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/scenes/insights/insightSceneLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export const insightSceneLogic = kea<insightSceneLogicType>([
{ shortId, mode, subscriptionId }, // url params
{ dashboard, ...searchParams }, // search params
{ filters: _filters, q }, // hash params
{ method, initial } // "location changed" event payload
{ initial } // "location changed" event payload
) => {
const insightMode =
mode === 'subscriptions'
Expand Down Expand Up @@ -223,7 +223,7 @@ export const insightSceneLogic = kea<insightSceneLogicType>([
}

// reset the insight's state if we have to
if (initial || method === 'PUSH' || filters || q) {
if (initial || filters || q) {
if (insightId === 'new') {
const teamFilterTestAccounts = values.currentTeam?.test_account_filters_default_checked || false
values.insightLogicRef?.logic.actions.setInsight(
Expand Down
Loading