fix(insights): Don't reset new insight when recording opened 2.0

[Twixes]

Problem

Second attempt at #21424 (CC @webjunkie):

Screen.Recording.2024-04-09.at.09.39.07.mov

Reported in ZEN-12286 (issue #1).

Changes

Previously I tried to fix this by updating insightSceneLogic URL handling, but in principle the existing handling is so much more correct than not, that I don't that's what needs to change. It's sessionPlayerModalLogic.ts that really is the offender. It pushes the sessionRecordingId change as a new browsing history item, and I think it shouldn't be doing that.

The problem from the recording above no longer occurs.

[github-actions]

Size Change: 0 B

Total Size: 845 kB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	845 kB

_{compressed-size-action}

[Twixes]

Bump @daibhin

[daibhin]

@Twixes sorry, I've been swamped with support and interviews the last couple of days. On my list to look at this today - thanks for the prompt

[daibhin]

Funnily enough I tested this and it looks like navigating backwards changes the URL but doesn't even close the player modal. Haven't found anything else affected by this so happy to go with it