Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Concise titles for the top nav #18856

Merged
merged 10 commits into from
Nov 28, 2023
Merged

feat: Concise titles for the top nav #18856

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5094b5
Concise titles for the top nav
benjackwhite Nov 23, 2023
5a80d5c
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 23, 2023
5cf91ba
Changes
benjackwhite Nov 23, 2023
ad90a81
Fix
benjackwhite Nov 23, 2023
cdcf5a9
Merge branch 'master' into feat/concise-nav
benjackwhite Nov 23, 2023
a7f5086
Merge branch 'master' into feat/concise-nav
benjackwhite Nov 28, 2023
86fbd87
Update UI snapshots for `webkit` (2)
github-actions[bot] Nov 28, 2023
0d73672
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 28, 2023
66c231a
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 28, 2023
a75fe26
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/layout/navigation-3000/navigationLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
[
{
identifier: Scene.ProjectHomepage,
label: 'Project homepage',
label: 'Home',
icon: <IconHome />,
to: urls.projectHomepage(),
},
Expand All @@ -321,13 +321,13 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
},
{
identifier: Scene.Events,
label: 'Event explorer',
label: 'Events',
icon: <IconLive />,
to: urls.events(),
},
{
identifier: Scene.DataManagement,
label: 'Data management',
label: 'Data',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other changes are great, we can't go with this though. There's no data under "Data" here – that lives in "Events" and "People". "Data management" is just about the shape of data. Hence I propose we rename it to the industry-standard "Taxonomy" (though we've got a lot of work left in that regard), and move it below both "People". Or just move while keeping "Data management".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "Taxonomy".

If we were worried about too much change at once, we keep "Data management" for a while and move it as you suggest, then change it to Taxonomy at a later date, maybe alongside some improvements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just taxonomy though 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving away from "Data" would avoid confusion with "Data warehouse" down the line, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried something different (see screenshot)...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the pragmatic approach here? I think data sufficiently gets the point across, even if there is technically data in other places.

icon: <IconDatabase />,
logic: isUsingSidebar ? dataManagementSidebarLogic : undefined,
to: isUsingSidebar ? undefined : urls.eventDefinitions(),
Expand Down