feat: Concise titles for the top nav #18856

benjackwhite · 2023-11-23T13:58:22Z

Problem

We discussed shorting the top nav item names. This would do that.

Changes

Changes the remaining longer text items to smaller ones

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

posthog-bot · 2023-11-23T14:07:00Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Twixes · 2023-11-23T14:07:25Z

frontend/src/layout/navigation-3000/navigationLogic.tsx

-                            label: 'Data management',
+                            label: 'Data',


I think the other changes are great, we can't go with this though. There's no data under "Data" here – that lives in "Events" and "People". "Data management" is just about the shape of data. Hence I propose we rename it to the industry-standard "Taxonomy" (though we've got a lot of work left in that regard), and move it below both "People". Or just move while keeping "Data management".

I like "Taxonomy".

If we were worried about too much change at once, we keep "Data management" for a while and move it as you suggest, then change it to Taxonomy at a later date, maybe alongside some improvements.

It's not just taxonomy though 🤔

Moving away from "Data" would avoid confusion with "Data warehouse" down the line, too.

Tried something different (see screenshot)...

What's the pragmatic approach here? I think data sufficiently gets the point across, even if there is technically data in other places.

github-actions · 2023-11-23T15:52:18Z

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.83 MB

_{compressed-size-action}

# Conflicts: # frontend/__snapshots__/posthog-3000-navigation--navigation-base.png

posthog-bot · 2023-11-28T09:59:41Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-11-28T10:07:58Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Twixes

PostHog/posthog.com#7227 (comment) just reminded me we should also turn "Project settings" into just "Settings" @benjackwhite
Regardless, this PR makes pure sense

Twixes · 2023-11-28T13:31:31Z

frontend/__snapshots__/posthog-3000-navigation--navigation-base.png

Ah, forgot about breadcrumbs though: these need to be updated from both Homepage and Event Explorer

Well, that was quick @benjackwhite Here's a follow-up PR idea then 😅

corywatilo · 2023-11-28T16:14:52Z

I don't think renaming "Event explorer" to "Events" is the right move here. "Events" makes me think it's where I can manage events. I had "Live events" in some mocks, which I think is a little more clear that it's recent/near-realtime activity. Could also make a case for "Activity". But there's an important distinction between this and the actual Data management → Events section.

…18949) * fix: re-add background to tertiary button * final color * Update UI snapshots for `chromium` (1) * Fix button styles to allow secondary to be transparent * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * all styles in default state * button active states * fix full width * remove custom nav styling as buttons now 3px shorter * tertiary danger hover highlight * muted stealth when not active * button sizes * move min-height to chrome * side buttons in primary * change sidepanel buttons to tertiary * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix border radius * dark mode colors * remove unused styles * fix: set metadata when level change (#18899) * set user analytics metadata when membership level is changed * also set whenever user is updated since that includes updating current org * fix tests * fix other tests * style(3000): Align border radius to 6px in 3000 (#18866) * style: Align border radius to 6px in 3000 * Only affect .posthog-3000 * Also tune some non-4px radii * Add radius comment Co-authored-by: David Newell <[email protected]> * Fix missing warehouse mocks and strictly prevent toasts * Don't affect utility classes --------- Co-authored-by: David Newell <[email protected]> * fix(3000): various ui fixes (#18861) * subtle links in the funnel legend * tooltip styles * funnel glyphs and line * retention table * gray lettermark * breakdown tag * Update UI snapshots for `webkit` (2) * Update UI snapshots for `chromium` (1) * consistent bg naming * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * fix retention table css --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(plugin-server): Remove Postgres-based plugin error logging in favor of existing ClickHouse-based approaches (#18764) * fix: delay usage report sending on sunday (#18900) delay usage report sending on sunday * feat(hogql): run filter based insights via hogql (undo revert) (#17645) * chore(data-warehouse): fix close button (#18918) fix close button * feat: Only show other recordings if there are no pinned ones by default (#18915) * fix(trends): convert any missing property operators to the default of exact (#18895) * Convert any missing property operators to the default of exact * Handle undefined values * Check for undefined values * feat(3000): Make nav usable on mobile (#18912) * chore(3000): updated tag colors (#18786) * updated tag colors * darkened warning text * Enable 3000 snapshots * Update UI snapshots for `webkit` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Lint CSS --------- Co-authored-by: Michael Matloka <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore(plugin server): add OS version to person properties (#18924) * feat: Concise titles for the top nav (#18856) * fix(groups): add debounce to search (#18927) * style(3000): Clean up segmented buttons (#18897) * style(3000): Make segmented buttons feel like IRL radio buttons * Fix font size * Revert full press * Update query snapshots * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: update es build (#18917) * chore: update ESBuild * chore: update ESBuild * more logging collapsing * Fix * fiddling * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * end when finished if not --dev --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore(plugin-server): add deprecated imports list, log if they are us… (#18726) * chore(3000): More styling tweaks (#18923) * Align more rounding * Align switch. select, input sizing with buttons * Resolve extra UI snags * Fix 3000-dependency * Fix one more stray divider * Remove legacy `description` prop of `PageHeader` * Update UI snapshots for `webkit` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Make "New insight" button regular size * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(surveys): be able to drag and reorder questions (#18763) * reorder questions wip * reorder questions * address comments and open question box to where it's dragged * import linter fix * key prop error * rotate drag handle icon * add back auto disappear * chore(plugin-server): only inject imports that are used by the plugin and remove unused plugin imports (#18934) * fix: Swap canvas state var and remove it on unmount (#18922) * fix: Support modal url changes (#18937) * feat(3000): Relabeled apps to data pipeline, re-ordered nav (#18919) * relabeled apps to data pipeline, re-ordered nav * Update UI snapshots for `chromium` (1) * RIP connectors → apps * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore(plugin-server): bump node-rdkafka to 2.18.0 (librdkafka 2.3.0) (#18420) * revert(plugin-server): bump node-rdkafka to 2.18.0 (librdkafka 2.3.0) (#18420) (#18941) * feat: Fixed up feature previews panel (#18931) * fix: PersonDisplay links should be the new subtle style (#18932) * fix: Added missing 3000 parts for exporter (#18913) * fix: e2e tests flakiness with unit image (#18933) * Change celery metrics port so it doesn't clash with webserver * Change back to unit image * chore(deps): bump aiohttp from 3.8.6 to 3.9.0 (#18920) * chore(deps): bump aiohttp from 3.8.6 to 3.9.0 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.6 to 3.9.0. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.8.6...v3.9.0) --- updated-dependencies: - dependency-name: aiohttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * update properly --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Paul D'Ambra <[email protected]> * reset snapshots * reset button snapshots * merge cleanup * final merge * remove old snapshots * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * reset snapshots * change onboaring to primary-alt in 3000 * add back in upwards motion on hover * fix segmented button styles * restore button heights * padding adjacent to icons in buttons * side action hover state * Update UI snapshots for `chromium` (1) * reset snapshots * danger colors and unused color cleanup * darken icons on hover * restore all chrome hover / press depths * increase navbar padding * fix clearable select * fix inspector button in session replay * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix rebase issues * retain legacy lemon select styles * improve active / hover states on segmented button * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (1) * Avoid extra margin between 3D buttons This allows for a slightly nicer overlaying effect * Update UI snapshots for `chromium` (1) * Update query snapshots * Update query snapshots * Update UI snapshots for `chromium` (1) * Update query snapshots * Update UI snapshots for `chromium` (1) * Update query snapshots * reset snapshots * always show danger icon opacity as 1 * stop content overflow * set full width horizontal padding * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * rotate shadows on sidepanel buttons * Update UI snapshots for `chromium` (1) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben White <[email protected]> Co-authored-by: Raquel Smith <[email protected]> Co-authored-by: Thomas Obermüller <[email protected]> Co-authored-by: ted kaemming <[email protected]> Co-authored-by: Eric Duong <[email protected]> Co-authored-by: Tom Owers <[email protected]> Co-authored-by: Michael Matloka <[email protected]> Co-authored-by: Cory Watilo <[email protected]> Co-authored-by: Michael Matloka <[email protected]> Co-authored-by: Juraj Majerik <[email protected]> Co-authored-by: Paul D'Ambra <[email protected]> Co-authored-by: Brett Hoerner <[email protected]> Co-authored-by: Li Yi Yu <[email protected]> Co-authored-by: Frank Hamand <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Concise titles for the top nav

b5094b5

benjackwhite requested a review from a team November 23, 2023 13:58

Update UI snapshots for chromium (1)

5a80d5c

Twixes reviewed Nov 23, 2023

View reviewed changes

benjackwhite added 3 commits November 23, 2023 15:12

Changes

5cf91ba

Fix

ad90a81

Merge branch 'master' into feat/concise-nav

cdcf5a9

benjackwhite requested review from andyvan-ph, Twixes and corywatilo November 28, 2023 09:49

benjackwhite and others added 4 commits November 28, 2023 10:50

Merge branch 'master' into feat/concise-nav

a7f5086

# Conflicts: # frontend/__snapshots__/posthog-3000-navigation--navigation-base.png

Update UI snapshots for webkit (2)

86fbd87

Update UI snapshots for chromium (1)

0d73672

Update UI snapshots for chromium (2)

66c231a

Update UI snapshots for chromium (1)

a75fe26

Twixes approved these changes Nov 28, 2023

View reviewed changes

benjackwhite merged commit 2144556 into master Nov 28, 2023

benjackwhite deleted the feat/concise-nav branch November 28, 2023 13:31

Twixes reviewed Nov 28, 2023

View reviewed changes

daibhin pushed a commit that referenced this pull request Nov 29, 2023

feat: Concise titles for the top nav (#18856)

2d94edc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Concise titles for the top nav #18856

feat: Concise titles for the top nav #18856

benjackwhite commented Nov 23, 2023 •

edited

Loading

posthog-bot commented Nov 23, 2023

Twixes Nov 23, 2023

andyvan-ph Nov 23, 2023

benjackwhite Nov 23, 2023

andyvan-ph Nov 23, 2023

benjackwhite Nov 23, 2023

corywatilo Nov 23, 2023

github-actions bot commented Nov 23, 2023 •

edited

Loading

posthog-bot commented Nov 28, 2023

posthog-bot commented Nov 28, 2023

Twixes left a comment

Twixes Nov 28, 2023

Twixes Nov 28, 2023

corywatilo commented Nov 28, 2023 •

edited

Loading

feat: Concise titles for the top nav #18856

feat: Concise titles for the top nav #18856

Conversation

benjackwhite commented Nov 23, 2023 • edited Loading

Problem

Changes

How did you test this code?

posthog-bot commented Nov 23, 2023

📸 UI snapshots have been updated

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 23, 2023 • edited Loading

posthog-bot commented Nov 28, 2023

📸 UI snapshots have been updated

posthog-bot commented Nov 28, 2023

📸 UI snapshots have been updated

Twixes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

corywatilo commented Nov 28, 2023 • edited Loading

benjackwhite commented Nov 23, 2023 •

edited

Loading

github-actions bot commented Nov 23, 2023 •

edited

Loading

corywatilo commented Nov 28, 2023 •

edited

Loading