Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Concise titles for the top nav #18856

Merged
merged 10 commits into from
Nov 28, 2023
Merged

feat: Concise titles for the top nav #18856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5094b5
Concise titles for the top nav
benjackwhite Nov 23, 2023
5a80d5c
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 23, 2023
5cf91ba
Changes
benjackwhite Nov 23, 2023
ad90a81
Fix
benjackwhite Nov 23, 2023
cdcf5a9
Merge branch 'master' into feat/concise-nav
benjackwhite Nov 23, 2023
a7f5086
Merge branch 'master' into feat/concise-nav
benjackwhite Nov 28, 2023
86fbd87
Update UI snapshots for `webkit` (2)
github-actions[bot] Nov 28, 2023
0d73672
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 28, 2023
66c231a
Update UI snapshots for `chromium` (2)
github-actions[bot] Nov 28, 2023
a75fe26
Update UI snapshots for `chromium` (1)
github-actions[bot] Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified frontend/__snapshots__/posthog-3000-navigation--navigation-base.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot about breadcrumbs though: these need to be updated from both Homepage and Event Explorer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was quick @benjackwhite Here's a follow-up PR idea then 😅

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-insights--retention--webkit.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/scenes-app-insights--retention.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 9 additions & 9 deletions frontend/src/layout/navigation-3000/navigationLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
[
{
identifier: Scene.ProjectHomepage,
label: 'Project homepage',
label: 'Home',
icon: <IconHome />,
to: urls.projectHomepage(),
},
Expand All @@ -321,24 +321,24 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
},
{
identifier: Scene.Events,
label: 'Event explorer',
label: 'Events',
icon: <IconLive />,
to: urls.events(),
},
{
identifier: Scene.DataManagement,
label: 'Data management',
icon: <IconDatabase />,
logic: isUsingSidebar ? dataManagementSidebarLogic : undefined,
to: isUsingSidebar ? undefined : urls.eventDefinitions(),
},
{
identifier: Scene.PersonsManagement,
label: 'People',
icon: <IconPeople />,
logic: isUsingSidebar ? personsAndGroupsSidebarLogic : undefined,
to: isUsingSidebar ? undefined : urls.persons(),
},
{
identifier: Scene.DataManagement,
label: 'Data management',
icon: <IconDatabase />,
logic: isUsingSidebar ? dataManagementSidebarLogic : undefined,
to: isUsingSidebar ? undefined : urls.eventDefinitions(),
},
],
[
{
Expand Down