-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update active skill checks to compare by base gem where appropriate #7126
Merged
LocalIdentity
merged 27 commits into
PathOfBuildingCommunity:dev
from
sida-wang:update-skillname-tag
Jan 2, 2024
Merged
Update active skill checks to compare by base gem where appropriate #7126
LocalIdentity
merged 27 commits into
PathOfBuildingCommunity:dev
from
sida-wang:update-skillname-tag
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
LocalIdentity
approved these changes
Jan 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7121, fixes #7105, fixes #7146, fixes #7187.
Description of the problem being solved:
Currently skill name matching is performed on exact matches. @Paliak recently introduced logic to match against the base gem for Replica Dragonfang's Flight in #7101.
This PR updates the logic to use the gem's
gameId
which is the same across variants and applies the check to the "SkillName" type inmodStore.lua
as well as theifSkill
check inConfigTab.lua
which can be activated using theincludeTransfigured
option.Implements a helper function in
CalcTools.lua
calcLib.getGameIdFromGemName(gemName, dropVaal)
which performs lookups indata.gemForBaseName
anddata.gems
to get thegameId
. This includes a type check on the input to ensure string due to thelistOrSingleIfOption
function passing the entire table to the function if no table entries satisfy the condition. ThedropVaal
option provides a boolean option to find the base non-vaal gem of a skill which has been used throughout this PR. The option is kept in case specific scenarios are identified in the future which require Vaal gems to be treated separately to their non-Vaal counterparts.Performed a full pass of all
type = "SkillName"
tags andifSkill
tags in the source code to update them to the new logic where appropriate.Steps taken to verify a working solution:
Non-reaper damage penalty no longer applying across variants

Tavukai and Mark of the Red Covenant now applying to SRS variants.
