Fix config options not applying to Vaal skill gems #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jan 24, 2024
Wires77
pushed a commit
to Wires77/PathOfBuilding
that referenced
this pull request
Mar 23, 2024
…munity#7300) * fix: set skillName match to use function * fix: method of getting base gem from vaal gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7292, fixes #7298 .
Description of the problem being solved:
#7126 introduced a bug where the ModStore comparison would use
cfg.SkillGemwith the intent to save a function call as theGameIdseemed to be immediately accessible. This is not the case for item provided skills as fixed in #7291 and also presents an issue for Vaal skill gems as the comparison should be based on the base skill.This PR removes the logic accessing
cfg.SkillGemin favouring of usingcalcLib.getGameIdFromGemNamefor all the comparisons (essentially superseding #7291).A further change is made to update the logic that applies the
dropVaalflag incalcLib.getGameIdFromGemName. This was using agsubwhich proved problematic for skills like Reap, Caustic Arrow, Dominating blow etc where the gemIds of the Vaal gem differ with the base gemIds in more than just aVaalterm.A lookup table from VaalGemId => BaseGemId has been implemented in
Data.luato allow for a robust method of obtaining the base gems of vaal gems.Steps taken to verify a working solution:
After screenshot:
#7298 after
