Exclude extra ascendancies from node counts #6949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Dec 6, 2023
LocalIdentity
added
user-interface
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Dec 9, 2023
* upstream-dev: (369 commits) Update spec Export bases + tincture + stat descriptions Fix IsSupport Spec Fix skillgems Fix Skill gems dat Tincture export start Additional Files Update Spec Adding gemeffects.dat (PathOfBuildingCommunity#6974) Add support for toggling ineligible configurations (PathOfBuildingCommunity#5950) Add support for search input to Configuration tab (PathOfBuildingCommunity#6178) Fix spelling Fix Variable casing Ngahamu -> Ngamahu (PathOfBuildingCommunity#6955) Release 2.35.5 Release 2.35.5 (PathOfBuildingCommunity#6951) Exclude extra ascendancies from node counts (PathOfBuildingCommunity#6949) Fixed dissolution of the flesh changing maximum hit pools (PathOfBuildingCommunity#6791) Release 2.35.4 Release 2.35.4 (PathOfBuildingCommunity#6947) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6928
Description of the problem being solved:
Extra ascendancies were being counted for ascendancy node counts for warnings and tooltips. This simply excludes the current ones from those counts.
If we end up having a core system for secondary ascendancies, or this becomes a regular feature, we might want to add some better display for this. This implementation won't add any warnings or signs that you've allocated too many nodes in the secondary ascendancy.
Before screenshot:
After screenshot: