-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for toggling ineligible configurations #5950
Merged
LocalIdentity
merged 10 commits into
PathOfBuildingCommunity:dev
from
Peechey:feature/toggle_configs
Dec 8, 2023
Merged
Add support for toggling ineligible configurations #5950
LocalIdentity
merged 10 commits into
PathOfBuildingCommunity:dev
from
Peechey:feature/toggle_configs
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6afd19a
to
b63035e
Compare
deathbeam
reviewed
May 4, 2023
add height to scrollbar to account for button pushing everything down
LocalIdentity
approved these changes
Dec 8, 2023
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Dec 9, 2023
* upstream-dev: (369 commits) Update spec Export bases + tincture + stat descriptions Fix IsSupport Spec Fix skillgems Fix Skill gems dat Tincture export start Additional Files Update Spec Adding gemeffects.dat (PathOfBuildingCommunity#6974) Add support for toggling ineligible configurations (PathOfBuildingCommunity#5950) Add support for search input to Configuration tab (PathOfBuildingCommunity#6178) Fix spelling Fix Variable casing Ngahamu -> Ngamahu (PathOfBuildingCommunity#6955) Release 2.35.5 Release 2.35.5 (PathOfBuildingCommunity#6951) Exclude extra ascendancies from node counts (PathOfBuildingCommunity#6949) Fixed dissolution of the flesh changing maximum hit pools (PathOfBuildingCommunity#6791) Release 2.35.4 Release 2.35.4 (PathOfBuildingCommunity#6947) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5944
Description of the problem being solved:
Users may want to theory craft builds with configs that don't apply to their current setup and therefore aren't shown. This PR adds a toggle to the ConfigTab that allows an internal list of configs to be shown regardless of eligibility.
At some point we may want to give users the ability to show almost every single config option, but I think this is a good first solution. Keeping as Draft to discuss which configurations to whitelist.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Should work on any build, it's a UI change
After screenshot: