Fixed dissolution of the flesh changing maximum hit pools

[ProFrenchToast]

Added a flag to the modifier on dissolution of the flesh to change recoverable life to full life pool rather than just unreserved life.

Description of the problem being solved:

Reserving life with dissolution of the flesh incorrectly reduces maximum hit pools. In game any skills which reserve life are automatically disabled when too much life is reserved through dissolution of the flesh.

Steps taken to verify a working solution:

• Created a build that uses dissolution of the flesh .
• Added an aura that reserves life.
• Checked that maximum hit pool is uneffected buy adding the aura.

Link to a build that showcases this PR:

https://pobb.in/Eniw8-R3U0Ro

Before screenshot:

This screenshot shows the maximum hit pool is based on the unreserved life pool when dissolution of the flesh is equipped.

After screenshot:

This screenshot shows the maximum hit pool is based on the total life pool when dissolution of the flesh if equipped.

[Regisle]

Thanks for the contribution, there are a few things I would like tested with this, how does it interact with Midnight Bargain as I assume that life doesnt get unreserved from too much damage, same with Relic of the Pact and its skill, as if I remember correctly that is a major issue for that skill

I think overall this change is good, but would like those 2 edge cases tested (and preferably fixed if they are an issue)

[ProFrenchToast]

Tested Midnight Bargin and Relic of the Pact neither is disabled by taking damage meaning that life reserved by these means do effect max hit pool even with dissolution of the flesh. I understand why Midnight Bargin cannot be disabled but the skill granted by Relic of the Pact I would expected to just detonate similar to how auras get disabled.

I will look into how best to cover these two edge cases.

[ProFrenchToast]

Added a new stat that contains the % of a given pool that cannot be unreserved, for example by Midnight Bargin or Blood Sacrament. This new stat uses the mod ExtraLifeReserved or ExtraManaReserved as a base to cover items with a fixed reservation such as Midnight Bargin and any skill with the flag HasUncancellableReservation has its reservation (post reservation efficiency calculations) added.

This will need to be changed if any uncancellable flat reservations are added to the game.

Build showing edge cases covered: https://pobb.in/hCEhMznR-1sV

Screenshot showing original behaviour. Max hit is uneffected by reserving an aura on life.

Screenshot showing Midnight Bargin does effect max hit while aura reserved on life does not.

Screenshot showing Blood Sacrament does effect max hit and stacks with Midnight Bargin and aura reserved on lilfe does not effect max hit.

Screenshot showing Blood Sacrament effect on max hit is effected by reservation modifiers.

[ProFrenchToast]

After some testing in trial of the acestors this behavior seems bugged in that mode. Sometimes during a trial a player will die when they still have auras that can be cancelled. I'm guessing this is due to how the death system in trial of the ancestors works. No issues like this were found in sanctum.

Also, need to test if the reservation from mines is cancellable like with auras. From my experience I have never died with mines still reserved but should be tested properly

POB: https://pobb.in/-fiA4FMloBRb

[ProFrenchToast]

tried to test mines reserved on life. It seems that the reservation for the mines gets cancelled rather than killing the player however the mines are not removed or detonated. No idea why this happens but at least it means no more changes.