-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Supreme Ego #4524
Add Support for Supreme Ego #4524
Conversation
093fa7a
to
4e47144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One missing edge case here is if you have a blasphemy curse + a self-cast curse, the self-cast one doesn't get registered, since we're at the curse limit because of the other curse already.
Fixed curse issue for both exceeding reservation and supreme ego disable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some nitpicks, but I'll just push those changes myself, this looks good otherwise
Fixes #4290.
Description of the problem being solved:
Add support for Supreme Ego and disable auras if they reserve more than maximum mana.
Greater than 100% reduced reservation and essence worm will behave weirdly with this patch so #4514 should be merged first.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/pob/BY5
Before screenshot:
After screenshot: