Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Supreme Ego #4524

Merged
merged 9 commits into from
Jul 11, 2022

Conversation

QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Jul 6, 2022

Fixes #4290.

Description of the problem being solved:

Add support for Supreme Ego and disable auras if they reserve more than maximum mana.
Greater than 100% reduced reservation and essence worm will behave weirdly with this patch so #4514 should be merged first.

Steps taken to verify a working solution:

  • Checking various auras ingame it seems any skill that have the aura tag will be effected by the mod this means tempest shield, blood and sand aren't affected at all.
  • Any skill of your that apply any aura to anything but you will not work, blasphemy, pride, smite aura, etc.
  • I haven't tested the mine auras but I presume they won't work. The current code disables them as well the aura effect only is based on one mine which I am not sure is correct but they are disabled with supreme ego anyway so it doesn't matter.
  • A curse in profane proxy won't work either but I don't think we fully support profane proxy so this doesn't work in pob.
  • I have the mana reserved multiplier capped at 100% (50% more aura effect) and I skip adding the aura if its reservation exceed maximum of resource. This should prevent easy abuse cases like slapping on a essence worm to try and get aura effect as it will cause those aura that exceed 100% to not be enabled.
  • The discrepancy for discipline in the screen shot is caused by low mana rounding errors I think.

Link to a build that showcases this PR:

https://poe.ninja/pob/BY5

image

Before screenshot:

image
image

After screenshot:

image
image

@QuickStick123 QuickStick123 changed the title Add support for Supreme ego implementation Add Support for Supreme Ego Jul 6, 2022
@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 7, 2022
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing edge case here is if you have a blasphemy curse + a self-cast curse, the self-cast one doesn't get registered, since we're at the curse limit because of the other curse already.

@QuickStick123
Copy link
Contributor Author

Fixed curse issue for both exceeding reservation and supreme ego disable.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some nitpicks, but I'll just push those changes myself, this looks good otherwise

@Wires77 Wires77 merged commit 7ef2e0f into PathOfBuildingCommunity:dev Jul 11, 2022
@QuickStick123 QuickStick123 deleted the Supreme-Ego branch September 15, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supreme Ego effect not properly calculated
2 participants