Correctly handle 100% reduced reservation efficiency and greater. #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the multiplier of 0 * infinity equaling infinity not zero. extend to reduced mana reserved as well
…fficiency behave as 100% reduced as in game.
QuickStick123
changed the title
QuickStick123
added
bug
Wires77
approved these changes
Jul 10, 2022
QuickStick123
deleted the
Fix--100-mana-reseravtion-efficiency-and-essence-worm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4332.
Description of the problem being solved:
This fixes sources that reduce mana reserved to zero not applying globally on infinite mana reservations such as 100 reduced mana efficiency. This primarily is for essence worm.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/pob/BMq
Screenshots
Essence worm + memory vault (socketed in essence worm)
Before
After
2 Essence worms not socketed (160% reduced efficiency)
Before
After
2 Essence worms socketed
Before
After