Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supreme Ego effect not properly calculated #4290

Closed
2 tasks done
xmdsx2 opened this issue Mar 17, 2022 · 3 comments · Fixed by #4524
Closed
2 tasks done

Supreme Ego effect not properly calculated #4290

xmdsx2 opened this issue Mar 17, 2022 · 3 comments · Fixed by #4524
Labels
enhancement New feature, calculation, or mod

Comments

@xmdsx2
Copy link

xmdsx2 commented Mar 17, 2022

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Supreme ego's new effect is to add 1% more aura effect per 2% of mana reserved. This means that, say, Hatred at 50% reservation (70% after Ego) would have 37.5% more aura effect, which PoB seems to completely ignore. I have tested the keystone in game and the damage of my main skill is visibly and numerically affected.

What is the actual behaviour/value?

PoB ignores the aura effect multiplier that should be added with the keystone. In my character I use Hatred aura, with 50% base reservation and 75% with the keystone. This should add 37.5% more effect, as is shown in-game before and after picking the keystone:
image
image
PoB ignores it as shown below:
image

How to reproduce the issue

Simply run an aura of your choice (in my example I use Hatred as that is my main aura) and pick/remove the keystone in-game and then in PoB and you will see the damage in PoB is unchanged and you have to add the "more aura effect" by hand under Custom Modifiers tab.

Build code

https://pastebin.com/EvwkYsAw

Screenshots

No response

@xmdsx2 xmdsx2 added the bug Something isn't working label Mar 17, 2022
@xmdsx2
Copy link
Author

xmdsx2 commented Mar 17, 2022

I just realized the PoB screenshot is not properly set. I changed to the auras setup to show they're the only auras I have, but I did not show my main skill being affected. It goes as follows:
image

@learn2draw
Copy link
Contributor

Red text isn't supported, would be a feature request and not a bug

@xmdsx2
Copy link
Author

xmdsx2 commented Mar 17, 2022

Red text isn't supported, would be a feature request and not a bug

Sorry, this is my very first time using github and I didn't even see that option xd

@Lothrik Lothrik added enhancement New feature, calculation, or mod and removed bug Something isn't working labels Jun 24, 2022
@Lothrik Lothrik mentioned this issue Jun 24, 2022
2 tasks
Wires77 pushed a commit that referenced this issue Jul 11, 2022
* Set aura effect to 0% if reserved mana exceeds maximum mana

* Supreme ego implementation

* remove conprint I missed.

* fix some conflicts

* remove temporary fix

* Handle disabling auras more generally and efficiently

* Correctly handle curses and minor cleanup.

* Apply suggestions from code review

Co-authored-by: Wires77 <[email protected]>

Fixes #4290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants