Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xlsx reader loading sheets with comments #420

Closed
wants to merge 3 commits into from
Closed

Fix xlsx reader loading sheets with comments #420

wants to merge 3 commits into from

Conversation

xklid101
Copy link
Contributor

Fix #375

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

When opening xlsx file that contains comments with xlsx reader, phpspreadsheet worksheet contains one more empty comment on left next every original comment

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment than for the other PR, we should avoid relying on pre-existing file for tests to avoid repository size growth. Instead this test would probably be a good fit for a functional test (write and read for multiple formats). You'll find example on existing tests.

@xklid101
Copy link
Contributor Author

Check my latest commits, I've done some changes. If anything else to be done, let mi know and I'll try to do it. Or post some comments... Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants