Reader\Xlsx loads one empty comment for each proper comment in spreadsheet

[xklid101]

This is:

- [x] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

For each comment load just one proper comment into sheet

What is the current behavior?

When sheet has some comment, Xlsx reader loads two comments instead of one. The first has correct value and is placed in correct cell. The second one is empty and placed one cell left from proper comment

What are the steps to reproduce?

Create some xlsx file with comment e.g. in D4, load file with Reader\Xlsx and get output. Someone will see 2 comments in sheet - one in D4 (this is ok), and one empty in C4 (this is wrong)

Which versions of PhpSpreadsheet and PHP are affected?

branch develop, PHP 5.6

---

I believe the bug is here

PhpSpreadsheet/src/PhpSpreadsheet/Reader/Xlsx.php

Line 1410 in edae73b

$comment = $docSheet->getCommentByColumnAndRow((string) $column, $row + 1);

If I remove this:

$comment = $docSheet->getCommentByColumnAndRow((string) $column, $row + 1);

and insert that instead:

$comment = $docSheet->getCommentByColumnAndRow($column + 1, $row + 1);

everything is working and looks ok

[madorin]

I have the same problem, just tried to update from an earlier beta build to latest stable one.

[PowerKiKi]

Would one of you be able to submit a PR that would fix the bug and cover it with unit tests ?

[xklid101]

I'll try to do it asap

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[xklid101]

Pullrequest to fix this issue is ready to merge (or some comment needed)
#420