-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Xlsx loaded an extra empty comment for each real comment
- Loading branch information
Showing
3 changed files
with
46 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php | ||
|
||
namespace PhpOffice\PhpSpreadsheetTests\Functional; | ||
|
||
use PhpOffice\PhpSpreadsheet\Spreadsheet; | ||
|
||
class CommentsTest extends AbstractFunctional | ||
{ | ||
public function providerFormats() | ||
{ | ||
return [ | ||
['Html'], | ||
['Xlsx'], | ||
['Ods'], | ||
]; | ||
} | ||
|
||
/** | ||
* Test load file with comment in sheet to load proper | ||
* count of comments in correct coords. | ||
* | ||
* @dataProvider providerFormats | ||
* | ||
* @param $format | ||
*/ | ||
public function testComments($format) | ||
{ | ||
$spreadsheet = new Spreadsheet(); | ||
|
||
$spreadsheet->getActiveSheet()->getCell('E10')->setValue('Comment'); | ||
$spreadsheet->getActiveSheet() | ||
->getComment('E10') | ||
->getText() | ||
->createText('Comment to test'); | ||
|
||
$reloadedSpreadsheet = $this->writeAndReload($spreadsheet, $format); | ||
|
||
$commentsLoaded = $reloadedSpreadsheet->getSheet(0)->getComments(); | ||
self::assertCount(1, $commentsLoaded); | ||
|
||
$commentCoordinate = key($commentsLoaded); | ||
self::assertSame('E10', $commentCoordinate); | ||
} | ||
} |