Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODS-Component - Banners #115

Closed
B3nz01d opened this issue Apr 14, 2022 · 2 comments · Fixed by #438
Closed

ODS-Component - Banners #115

B3nz01d opened this issue Apr 14, 2022 · 2 comments · Fixed by #438

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Apr 14, 2022

Banners

Requirement

As a developer
I want to insert a banner in a page
So That I will get this ready to use component compatible with Orange design specifications and a11y requirements

DSM reference (To be updated)

General description

Component

For the component description please refer to the staging DSM

App Page

the page will propose to the user to describe the component and allow to see variants implementation in action.

Design specifications

User Experience

  • a new card is added in the component list
  • when the user taps on the card the component page is opened
  • In the variants list when the user taps on the Banner demo the demo page is opened

Anatomy

Component Page

  • Header:
    • title: "Banners"
    • back link: to components list page
    • Action icon: none
  • image: xxx.jpg
  • Text: intro text description in the DSM
  • Variant link list:
    • "Banners Demo"

Variant Demo Page

  • Header:
  • title: "Banners"
  • back link: to Banners description page
  • Action icon: none
  • Implementation example
  • a banner example is shown in the page
  • Customization bottom sheet
  • "text" : using choice chips
    • "short"
    • "long"
  • "button" : using choice chips
    • "side"
    • "under"

States

  • NA

Internationalization

  • NA

UX specifications

Interaction

  • All:
    *
  • Touch:
    • Nothing Specific
  • Keyboard:
    • Nothing specific

Animations

  • NA

Accessibility

Visual Accessibility

  • taken into account within the design creation process

Usage Accessibility

  • (?) Focus order - NA
  • (?) Focus loss expected behavior - NA
  • (?) Screen Reader - default OS behavior
  • (?) Switch Control

Technical specifications

https://m2.material.io/components/banners

@B3nz01d B3nz01d added 🔍 triage A new issue that needs to be treated user story An agile user story request ⚛️ Component styled labels Apr 14, 2022
@B3nz01d B3nz01d self-assigned this Apr 14, 2022
@B3nz01d B3nz01d assigned mccart77 and unassigned B3nz01d Feb 1, 2023
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Feb 17, 2023
@paulinea paulinea assigned dolinetouko and unassigned mccart77 Feb 17, 2023
dolinetouko added a commit that referenced this issue Feb 21, 2023
@dolinetouko dolinetouko linked a pull request Feb 21, 2023 that will close this issue
dolinetouko added a commit that referenced this issue Feb 21, 2023
dolinetouko added a commit that referenced this issue Feb 22, 2023
dolinetouko added a commit that referenced this issue Feb 27, 2023
dolinetouko added a commit that referenced this issue Feb 27, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
dolinetouko added a commit that referenced this issue Mar 1, 2023
@B3nz01d
Copy link
Collaborator Author

B3nz01d commented Mar 2, 2023

@paulinea I do not see this component in today's version

@paulinea
Copy link
Member

paulinea commented Mar 2, 2023

@B3nz01d Try again cause it has been delivered :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants