Skip to content

Commit

Permalink
[#115] Review : Change string file
Browse files Browse the repository at this point in the history
  • Loading branch information
dolinetouko committed Mar 1, 2023
1 parent 3decf9a commit 87a9654
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ fun ComponentBanners() {
maxCount = BannerCustomizationState.MaxTextCount
)
ComponentCountRow(
title = stringResource(id = R.string.component_banners_Buttons_count),
title = stringResource(id = R.string.component_banner_buttons_count),
count = buttonsCount,
minusIconContentDescription = stringResource(id = R.string.component_banner_remove_action_button),
plusIconContentDescription = stringResource(id = R.string.component_banner_add_action_button),
Expand All @@ -70,7 +70,7 @@ fun ComponentBanners() {
) {
Column {
OdsBanner(
message = if (hasTextLines) stringResource(id = R.string.component_banners_two_line_text) else stringResource(id = R.string.component_banners_one_line_text),
message = if (hasTextLines) stringResource(id = R.string.component_banner_two_line_text) else stringResource(id = R.string.component_banner_one_line_text),
button1Text = stringResource(id = R.string.component_snackbar_action_label),
buttonText = if (hasTextLines && hasButton) stringResource(id = R.string.component_snackbar_action_label) else null,
actionOnNewLine = !hasTextLines,
Expand All @@ -82,8 +82,8 @@ fun ComponentBanners() {
CommonTechnicalTextColumn(
componentName = OdsComponent.OdsBanner.name
) {
if (hasTextLines) TechnicalText(text = " message = \"${stringResource(id = R.string.component_banners_two_line_text)}\"")
else TechnicalText(text = " message = \"${stringResource(id = R.string.component_banners_one_line_text)}\"")
if (hasTextLines) TechnicalText(text = " message = \"${stringResource(id = R.string.component_banner_two_line_text)}\"")
else TechnicalText(text = " message = \"${stringResource(id = R.string.component_banner_one_line_text)}\"")
TechnicalText("")
TechnicalText(" divider = $hasDivider")
TechnicalText("")
Expand Down
6 changes: 3 additions & 3 deletions demo/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,13 @@
<string name="component_banners">Banners</string>
<string name="component_banners_description">A banner displays an important message which requires an action to be dismissed.</string>
<string name="component_banner_text_lines_count">Text lines count</string>
<string name="component_banners_Buttons_count">Buttons count</string>
<string name="component_banner_buttons_count">Buttons count</string>
<string name="component_banner_divider">Divider</string>
<string name="component_banner_image">Image</string>
<string name="component_banner_remove_action_button">Remove Line</string>
<string name="component_banner_add_action_button">Add Line</string>
<string name="component_banners_one_line_text">One line text string with one action.</string>
<string name="component_banners_two_line_text">Two lines text string with two actions. One to two lines is preferable on mobile and tablet.</string>
<string name="component_banner_one_line_text">One line text string with one action.</string>
<string name="component_banner_two_line_text">Two lines text string with two actions. One to two lines is preferable on mobile and tablet.</string>

<!-- Components Buttons -->
<string name="component_buttons">Buttons</string>
Expand Down

0 comments on commit 87a9654

Please sign in to comment.