Skip to content

Commit

Permalink
[#115] Review : Rename string
Browse files Browse the repository at this point in the history
  • Loading branch information
dolinetouko committed Mar 1, 2023
1 parent a5d10ac commit 3decf9a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ fun ComponentBanners() {
ComponentCountRow(
title = stringResource(id = R.string.component_banner_text_lines_count),
count = textLinesCount,
minusIconContentDescription = stringResource(id = R.string.component_card_remove_action_button),
plusIconContentDescription = stringResource(id = R.string.component_card_add_action_button),
minusIconContentDescription = stringResource(id = R.string.component_remove_action_button),
plusIconContentDescription = stringResource(id = R.string.component_add_action_button),
modifier = Modifier.padding(start = dimensionResource(id = R.dimen.screen_horizontal_margin)),
minCount = BannerCustomizationState.MinTextCount,
maxCount = BannerCustomizationState.MaxTextCount
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ fun ComponentCard(variant: Variant) {
ComponentCountRow(
title = stringResource(id = R.string.component_card_action_button_count),
count = actionButtonCount,
minusIconContentDescription = stringResource(id = R.string.component_card_remove_action_button),
plusIconContentDescription = stringResource(id = R.string.component_card_add_action_button),
minusIconContentDescription = stringResource(id = R.string.component_remove_action_button),
plusIconContentDescription = stringResource(id = R.string.component_add_action_button),
modifier = Modifier.padding(start = dimensionResource(id = R.dimen.screen_horizontal_margin)),
minCount = CardCustomizationState.MinActionButtonCount,
maxCount = CardCustomizationState.MaxActionButtonCount
Expand Down
4 changes: 2 additions & 2 deletions demo/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@
<string name="component_element_cancel_cross">Cancel cross</string>
<string name="component_element_divider">Divider</string>
<string name="component_demo">%s demo</string>
<string name="component_remove_action_button">Remove action button</string>
<string name="component_add_action_button">Add action button</string>


<!-- Components App bars: top -->
Expand Down Expand Up @@ -150,8 +152,6 @@
<string name="component_card_element_card">Card</string>
<string name="component_card_clickable">Clickable card</string>
<string name="component_card_action_button_count">Action buttons</string>
<string name="component_card_remove_action_button">Remove action button</string>
<string name="component_card_add_action_button">Add action button</string>
<string name="component_card_horizontal_image_position">Image position</string>
<string name="component_card_horizontal_image_position_start">Start</string>
<string name="component_card_horizontal_image_position_end">End</string>
Expand Down

0 comments on commit 3decf9a

Please sign in to comment.