Group validation errors by type #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjwebb
changed the title
Bjwebb
force-pushed
the
1117-group-validation
branch
from
25961ea to
604a0ee
Compare
|
This depends on OpenDataServices/lib-cove#9 and OpenDataServices/lib-cove-web#11 |
|
@Bjwebb Travis failed. |
|
Looks like its the bulk secret data tests that are failing. As discussed on standup, I think we can merge this without the bulk secret data tests passing (as they're a bit of a pain to update, and it's mostly as good to do them all in one go). |
|
Thanks for the changes @Bjwebb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1117