1118 one from many msg extra checks

[BibianaC]

Set up the ability to add one-from-many additional checks message (issue #1118).
The new messages are being prepared and will be added in a separate PR.

[Bjwebb]

Note: I have checked it manually in my terminal. When I spin a local server I receive an error message: KeyError: 'validator about the last work you did @Bjwebb do I need to do anything locally to be able to run it?

You need the most recent commit of lib-cove. Installing from the requirements file should get this.

[Bjwebb]

= 100 should be fine?

[BibianaC]

Yes

[Bjwebb]

This doesn't work, because heading_percentage contains the string of, so heading_percentage[:-1] is e.g. 14% o.

[BibianaC]

Right! I have fixed that.

[Bjwebb]

The approach looks good to me.

[robredpath]

I really like this approach:

• We can have as many or as few bands for each check as we want
• We can make the boundaries different for each check
• We can easily port the existing checks and improve them as we go

[BibianaC]

@robredpath and I have agreed to add the ability to have one-from-many additional checks to all the checks. By doing this, this PR will be able to be merged and be ready when the new validation errors are prepared. (@robredpath @Bjwebb I will let you know when this is the case so you can review it)

@Bjwebb do you know why Flake8 is failing with errors that were not failing before?

[Bjwebb]

@Bjwebb do you know why Flake8 is failing with errors that were not failing before?

When you added rangedict, you also updated the other requirements. Looks like the newest version of Flake8 picks up more errors than the older version.

[BibianaC]

@robredpath @Bjwebb The PR is more or less ready to review. The secret_data_tests is failing in assert json.load(fp) == json.load(fp_archive) when checking the difference between both files what I see is that the fp has an extra key validator. I don't know why this is happening.

[Bjwebb]

Sorry, the failing secret_data_tests was introduced in this PR #1129 (comment).

[BibianaC]

@Bjwebb If you think the code is good then it can be merged with the secret data tests failing.