Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] Group validation errors by type #1117

Closed
robredpath opened this issue Feb 14, 2019 · 3 comments
Closed

[1.2] Group validation errors by type #1117

robredpath opened this issue Feb 14, 2019 · 3 comments
Assignees

Comments

@robredpath
Copy link
Member

robredpath commented Feb 14, 2019

  • We already have identifiers for each kind of check
  • The work here is to categorise them and present them together
  • Risk is that ungrouped errors disappear
@robredpath robredpath assigned BibianaC and Bjwebb and unassigned BibianaC Feb 14, 2019
@robredpath
Copy link
Member Author

@Bjwebb
Copy link
Member

Bjwebb commented Feb 18, 2019

We already have identifiers for each kind of check

I think I said this. I'm referring to e.validator and e.validator_valuewhich we have for each error e from jsonschema. e.g. for missing fields, e.validator is required, so we can match for that.

The validation grouping prototype looks good to me.

@Bjwebb
Copy link
Member

Bjwebb commented Feb 27, 2019

I've split validation errors into 3 groups. Check out the demo dev deploy.

Currently modals are broken. How best to fix that depends on how much more we're changing the tables. The prototype docs only has two columns - is that what we want, or is it just shorthand for the larger table?

Bjwebb added a commit to OpenDataServices/lib-cove-web that referenced this issue Feb 28, 2019
Bjwebb added a commit to OpenDataServices/lib-cove-web that referenced this issue Feb 28, 2019
Bjwebb added a commit to OpenDataServices/lib-cove-web that referenced this issue Feb 28, 2019
Bjwebb added a commit that referenced this issue Mar 1, 2019
robredpath pushed a commit that referenced this issue Jun 7, 2019
robredpath pushed a commit that referenced this issue Jun 7, 2019
robredpath pushed a commit that referenced this issue Jun 7, 2019
robredpath pushed a commit that referenced this issue Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants