Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to select all injects with a 'select all' #1961

Closed
jborozco opened this issue Nov 29, 2024 · 2 comments
Closed

Ability to select all injects with a 'select all' #1961

jborozco opened this issue Nov 29, 2024 · 2 comments
Assignees
Labels
feature use for describing a new feature to develop solved The issue has been solved

Comments

@jborozco
Copy link

Description

See screenshot, this means tha in the curent state, we can't update more than 100 injects at the time
Image

@jborozco jborozco added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Nov 29, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Dec 2, 2024
@impolitepanda impolitepanda self-assigned this Dec 10, 2024
@RomuDeuxfois
Copy link
Member

Issue opened on XTM hub side to improv our datatable
https://github.com/FiligranHQ/xtm-hub/issues/227

@impolitepanda
Copy link
Member

Adter discussing this with the team (@EllynBsc, @guillaumejparis), this bug corresction has some side effects:

  • Undefined behaviors:
    • What happens when a user "select all" then changes page
    • What happens when a user "select all", then removes one element on current page
    • What happens when a user "select all", then removes one element on current page, then changes page
  • Design system integration:
    • We will have to modify the data table component we use to had a specific behavior, different from other data table within Filigran's other apps

What we will do is therefore:

  • Create a feature to specify points above
  • Treat this bug in a fast way by:
    • Adding a "select all" clickable link next to the the number of element in the toolbar bellow the data table
    • Ignore undefined behavior for now -> if the user changes the page or the selection, then we roll back to select all visible in page only
    • Change backend code for bulk tests, delete and update of injects in order to improve performances a bit and make use of the filters from the frontend

@EllynBsc EllynBsc modified the milestones: Bugs backlog, Release 1.11.0 Jan 2, 2025
@EllynBsc EllynBsc added feature use for describing a new feature to develop and removed bug use for describing something not working as expected labels Jan 2, 2025
@EllynBsc EllynBsc changed the title Selecting "all" in a list should select all items of the list, not only the 20 first visible Ability to select all injects with a 'select all' Jan 2, 2025
@impolitepanda impolitepanda added the solved The issue has been solved label Jan 9, 2025
@SamuelHassine SamuelHassine reopened this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved The issue has been solved
Projects
None yet
Development

No branches or pull requests

5 participants