Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fixes bulk operations not refreshing the datatables correctly #2216

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

impolitepanda
Copy link
Member

Proposed changes

  • [frontend] fix: bulk delete and update now ignores store
  • [frontend] fix: bulk update now correctly refreshes the data table
  • [frontend] feat: bulk test and delete now display a loading animation

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 15, 2025
[frontend] fix: bulk update now correctly refreshes the data table
[frontend] feat: bulk test and delete now display a loading animation
@impolitepanda impolitepanda force-pushed the bugfix/fix-slow-bulk-delete branch from 9bfca3a to 55e5595 Compare January 15, 2025 13:05
guillaumejparis and others added 2 commits January 15, 2025 14:06
[frontend] fix: bulk update now correctly refreshes the data table
[frontend] feat: bulk test and delete now display a loading animation
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.70%. Comparing base (d5401bf) to head (a4d4113).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2216   +/-   ##
=========================================
  Coverage     32.70%   32.70%           
  Complexity     1515     1515           
=========================================
  Files           582      582           
  Lines         18037    18037           
  Branches       1156     1156           
=========================================
  Hits           5899     5899           
  Misses        11874    11874           
  Partials        264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@impolitepanda impolitepanda merged commit b11f516 into master Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding asset groups in bulk to inject doesn't enable them in the UI
3 participants