Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend][frontend] Fixed an issue on injects where total number of injects was not correctly updated and bulk delete didn't refresh results #2207

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

impolitepanda
Copy link
Member

@impolitepanda impolitepanda commented Jan 14, 2025

Proposed changes

  • [backend] feat: changed return of bulk delete to return list of deleted injects
  • [frontend] fix: fixed total number of elements not being updated when creating or deleting an inject
  • [frontend] fix: fixed bulk delete not being reflected in datatables without refresh

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (51f58ec) to head (4f7c1ce).

Files with missing lines Patch % Lines
.../io/openbas/rest/inject/service/InjectService.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2207   +/-   ##
=========================================
  Coverage     32.69%   32.70%           
- Complexity     1513     1515    +2     
=========================================
  Files           582      582           
  Lines         18033    18037    +4     
  Branches       1156     1156           
=========================================
+ Hits           5896     5899    +3     
  Misses        11874    11874           
- Partials        263      264    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@impolitepanda impolitepanda changed the title [backend] feat: changed return of bulk delete to return list of delet… [backend][frontend] Fixed an issue on injects where total number of injects was not correctly updated and bulk delete didn't refresh results Jan 14, 2025
@impolitepanda impolitepanda force-pushed the bugfix/fix-bug-total-number branch 3 times, most recently from ab71ffa to 4f7c1ce Compare January 14, 2025 18:01
…ed injects

[frontend] fix: fixed total number of elements not being updated when creating or deleting an inject
[frontend] fix: fixed bulk delete not being reflected in datatables without refresh
@impolitepanda impolitepanda force-pushed the bugfix/fix-bug-total-number branch from 4f7c1ce to c3dc49d Compare January 15, 2025 08:10
@impolitepanda impolitepanda merged commit d5401bf into master Jan 15, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants