Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend][frontend] Ability to select all injects with a 'select all' #2163

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

impolitepanda
Copy link
Member

@impolitepanda impolitepanda commented Jan 7, 2025

Proposed changes

  • [backend] feat: added new bulk update, delete and test functions for injects
  • [backend] deprecate: marked existing bulk functions as deprecated
  • [frontend] feat: plugged the new bulk function in the injects tables for scenarios and simulations
  • [frontend] feat: select all now select all elements from all the pages in data tables
  • [frontend] feat: select all + any filter or text search set means that only the filterred element will count as selected

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

A few related bugs remains that where out of scope for this PR (issues to be created):

@impolitepanda impolitepanda force-pushed the issue/1961 branch 16 times, most recently from 6e0d26d to 9bab530 Compare January 8, 2025 16:42
@RomuDeuxfois
Copy link
Member

I have a bug on the bulk test.
We need to check if it comes from your PR or not.
Test replay: OK
Bulk test: NOK
image

We can have a look tomorrow.

@impolitepanda impolitepanda force-pushed the issue/1961 branch 2 times, most recently from f2d47ff to 9508921 Compare January 8, 2025 17:59
@impolitepanda
Copy link
Member Author

I have a bug on the bulk test. We need to check if it comes from your PR or not. Test replay: OK Bulk test: NOK image

We can have a look tomorrow.

It was indeed an error in my PR. Specification built without a simulation or scenario ID didn't work for bulk tests in this tab.

It also allowed me to see that the bulk test function of this screen only work on diplayed page. I created another bug to trace this:
#2174

@impolitepanda impolitepanda force-pushed the issue/1961 branch 4 times, most recently from ab1d830 to 3ace5a8 Compare January 9, 2025 10:25
@impolitepanda impolitepanda force-pushed the issue/1961 branch 4 times, most recently from fe18bc2 to 9ec1927 Compare January 9, 2025 14:17
…injects

[backend] deprecate: marked existing bulk functions as deprecated
[frontend] feat: plugged the new bulk function in the injects tables for scenarios and simulations
[frontend] feat: select all now select all elements from all the pages in data tables
[frontend] feat: select all + any filter or text search set means that only the filterred element will count as selected
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 76.59574% with 33 lines in your changes missing coverage. Please review.

Project coverage is 32.61%. Comparing base (0f26f1a) to head (98abc24).
Report is 1 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
.../io/openbas/rest/inject/service/InjectService.java 83.51% 9 Missing and 6 partials ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 36.36% 4 Missing and 3 partials ⚠️
...s/rest/inject_test_status/InjectTestStatusApi.java 0.00% 6 Missing ⚠️
...va/io/openbas/service/InjectTestStatusService.java 0.00% 4 Missing ⚠️
...enbas/rest/inject/form/InjectBulkUpdateInputs.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2163      +/-   ##
====================================================
+ Coverage             32.58%   32.61%   +0.02%     
- Complexity             1492     1512      +20     
====================================================
  Files                   575      580       +5     
  Lines                 17946    18056     +110     
  Branches               1139     1158      +19     
====================================================
+ Hits                   5848     5889      +41     
- Misses                11842    11903      +61     
- Partials                256      264       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@impolitepanda impolitepanda merged commit 173467c into release/1.11.0 Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants