-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend][frontend] Ability to select all injects with a 'select all' #2163
Conversation
6e0d26d
to
9bab530
Compare
openbas-api/src/main/java/io/openbas/rest/inject/form/InjectBulkProcessingInput.java
Outdated
Show resolved
Hide resolved
openbas-framework/src/main/java/io/openbas/utils/FilterUtilsJpa.java
Outdated
Show resolved
Hide resolved
openbas-framework/src/main/java/io/openbas/utils/FilterUtilsJpa.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/inject/service/InjectService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/resources/implants/caldera/macos/arm64/obas-implant-caldera-macos
Outdated
Show resolved
Hide resolved
9bab530
to
58564c7
Compare
f2d47ff
to
9508921
Compare
It was indeed an error in my PR. Specification built without a simulation or scenario ID didn't work for bulk tests in this tab. It also allowed me to see that the bulk test function of this screen only work on diplayed page. I created another bug to trace this: |
9508921
to
c269f8f
Compare
openbas-api/src/main/java/io/openbas/rest/inject/InjectApi.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/inject/InjectApi.java
Outdated
Show resolved
Hide resolved
ab1d830
to
3ace5a8
Compare
fe18bc2
to
9ec1927
Compare
…injects [backend] deprecate: marked existing bulk functions as deprecated [frontend] feat: plugged the new bulk function in the injects tables for scenarios and simulations [frontend] feat: select all now select all elements from all the pages in data tables [frontend] feat: select all + any filter or text search set means that only the filterred element will count as selected
9ec1927
to
98abc24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2163 +/- ##
====================================================
+ Coverage 32.58% 32.61% +0.02%
- Complexity 1492 1512 +20
====================================================
Files 575 580 +5
Lines 17946 18056 +110
Branches 1139 1158 +19
====================================================
+ Hits 5848 5889 +41
- Misses 11842 11903 +61
- Partials 256 264 +8 ☔ View full report in Codecov by Sentry. |
Proposed changes
Related issues
Checklist
Further comments
A few related bugs remains that where out of scope for this PR (issues to be created):
-> Issue Injects bulk update allows to update irrelevant fields #2165
-> Issue Injects list text search doesn't update the total number of elements when there are more than one page #2164