http: move xff logging to alert object #7148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 4860 instead of root field
|
I need to update the S-V test... |
|
Information: QA ran without warnings. Pipeline 6590 |
Codecov Report
@@ Coverage Diff @@
## master #7148 +/- ##
==========================================
+ Coverage 78.06% 78.14% +0.07%
==========================================
Files 628 628
Lines 185266 185272 +6
==========================================
+ Hits 144635 144783 +148
+ Misses 40631 40489 -142
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Mar 24, 2022
Done cf OISF/suricata-verify#797 and OISF/suricata-verify#796 |
|
Merged in #7187, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4860
but also https://redmine.openinfosecfoundation.org/issues/1369
Describe changes:
alert.xffsuricata-verify-pr: 796
OISF/suricata-verify#796
Replaces #7051 with moving into alert instead of taking care of http stuff